Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Added python 3.9 #12 #13

Merged
merged 1 commit into from Oct 20, 2021
Merged

Conversation

harsh7in
Copy link
Contributor

@harsh7in harsh7in commented Oct 19, 2021

Added python 3.9 in ci
fixed: #12

@harsh7in
Copy link
Contributor Author

hey @codesankalp, please review this.

@harsh7in harsh7in closed this Oct 19, 2021
@harsh7in harsh7in reopened this Oct 19, 2021
Copy link
Member

@atb00ker atb00ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I don't think any further change is required here, thanks @harsh-9in !

Copy link
Member

@atb00ker atb00ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, I can't merge!

Can you please remove .travis.yml file? We'll be able to merge it then, please ensure all the tests from .travis are moved to github action.

Reason: We used travis-ci in the past but that's not working very well so Gagan helped us move to GitHub actions which is what we are using for our CI needs now! 😄

@devkapilbansal
Copy link
Member

@atb00ker I can't find any travis file in the code, but checks still show travis-ci option. What causes this?

@codesankalp
Copy link
Member

codesankalp commented Oct 20, 2021

@devkapilbansal and @atb00ker, I think status checks are defined in branch protection rules: https://travis-ci.community/t/known-issue-travis-ci-reports-expected-waiting-for-status-to-be-reported-on-the-github-status-api-but-the-status-never-arrives/1154

@nemesifier
Copy link
Member

Argh, I can't merge!

Can you please remove .travis.yml file? We'll be able to merge it then, please ensure all the tests from .travis are moved to github action.

Reason: We used travis-ci in the past but that's not working very well so Gagan helped us move to GitHub actions which is what we are using for our CI needs now! smile

I removed the leftover travis configuration in the branch protection rule, are you allowed to merge now?

@atb00ker atb00ker merged commit 7897114 into openwisp:master Oct 20, 2021
@atb00ker
Copy link
Member

That worked, thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] Add python 3.8 and python 3.9, remove python 3.6
5 participants