move init to window load event #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using jazzmin this seems to be necessary, because otherwise the function is executed before django.jQuery is available.
atb00ker
reviewed
Nov 21, 2020
There was a problem hiding this comment.
If you change your commit to:
[javascript] Move init to window load event
then the travis-ci will pass.
As of the review on the rest of it.
I'll have to google somethings before I comment on that, for some reason, I have a feeling there would be more "django-way" out there.
|
Should be fixed by #10. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using jazzmin this seems to be necessary, because otherwise the function is executed before django.jQuery is available.