[QA] Increasing test coverage to 100% #186

Closes #186

django_freeradius/tests/__init__.py

@@ -2,6 +2,8 @@
 
 from django.core.management import call_command
 
+from django_freeradius.base.models import _encode_secret
+
 
 class CreateRadiusObjectsMixin(object):
     def _get_defaults(self, opts, model=None):
@@ -10,6 +12,9 @@ def _get_defaults(self, opts, model=None):
         return options
 
     def _create_radius_check(self, **kwargs):
+        if kwargs.get('value'):
+            kwargs['value'] = _encode_secret(kwargs['attribute'],
+                                             kwargs.get('value'))
         options = self._get_defaults(kwargs)
         rc = self.radius_check_model(**options)
         rc.full_clean()

django_freeradius/tests/base/test_admin.py

@@ -154,7 +154,6 @@ def test_radiuscheck_create_disabled_hash(self):
 
     def test_radiuscheck_admin_save_model(self):
         obj = self._create_radius_check(**_RADCHECK_ENTRY)
-        self.assertEqual(obj.value, _RADCHECK_ENTRY['value'])
         change_url = reverse('admin:{0}_radiuscheck_change'.format(self.app_name), args=[obj.pk])
         # test admin save_model method
         data = _RADCHECK_ENTRY_PW_UPDATE.copy()

django_freeradius/tests/base/test_models.py

@@ -66,6 +66,20 @@ def test_change_user_username(self):
         # ensure related records have been updated
         self.assertEqual(c.username, u.username)
 
+    def test_auto_value(self):
+        obj = self._create_radius_check(username='Monica',
+                                        value='Cam0_liX',
+                                        attribute='NT-Password',
+                                        op=':=')
+        self.assertEqual(obj.value, '891fc570507eef023cbfec043dd5f2b1')
+
+    def test_create_radius_check_model(self):
+        obj = self.radius_check_model.objects.create(username='Monica',
+                                                     new_value='Cam0_liX',
+                                                     attribute='NT-Password',
+                                                     op=':=')
+        self.assertEqual(obj.value, '891fc570507eef023cbfec043dd5f2b1')
+
 
 class BaseTestRadiusReply(object):
     def test_string_representation(self):
@@ -322,6 +336,12 @@ def test_change_user_username(self):
         # ensure related records have been updated
         self.assertEqual(ug.username, u.username)
 
+    def test_delete(self):
+        g = self._create_radius_group(name='test',
+                                      description='test')
+        g.delete()
+        self.assertEqual(self.radius_group_model.objects.all().count(), 2)
+
 
 class BaseTestRadiusBatch(object):
     def test_string_representation(self):