Skip to content
This repository has been archived by the owner on Sep 10, 2020. It is now read-only.

[tests] Added the missing tests to sample_radius #140

Merged
merged 1 commit into from Jul 9, 2018
Merged

[tests] Added the missing tests to sample_radius #140

merged 1 commit into from Jul 9, 2018

Conversation

rohithasrk
Copy link
Contributor

Improves #138

@coveralls
Copy link

coveralls commented Jul 9, 2018 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 3e4bac1 on rohithasrk:sample-app-tests into 3bd9000 on openwisp:master.

@rohithasrk rohithasrk force-pushed the sample-app-tests branch 2 times, most recently from cc75301 to b957c75 Compare July 9, 2018 17:48
@rohithasrk rohithasrk changed the title [tests] Add the missing TestUtils to sample_radius [tests] Added the missing tests to sample_radius Jul 9, 2018
@rohithasrk
Copy link
Contributor Author

While going through coveralls and the code, I still realised that we were not using all tests in sample_app yet. Also, notices that some of the tests are being repeated so added a skipIf decorator on them. This app is a great example of reusing all the tests and models.

@rohithasrk rohithasrk merged commit 3e4bac1 into openwisp:master Jul 9, 2018
@rohithasrk rohithasrk deleted the sample-app-tests branch July 9, 2018 18:13
@nemesifier
Copy link
Member

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rohithasrk @coveralls @nemesifier