Freeradius documentation #20

lillopaco · 2017-06-29T19:03:19Z

Added documentation for abstract models.

coveralls · 2017-06-29T19:08:38Z

Coverage remained the same at 100.0% when pulling b47d147 on freeradius_documentation into cfc018c on master.

nemesifier

Great job! Almost there. Please squash/fixup the commits and address my inline comments.

nemesifier · 2017-06-30T09:39:33Z

docs/source/general/abstract_models.rst

+        ),
+
+Extends Models
+----------------------


add blank line

nemesifier · 2017-06-30T09:39:46Z

docs/source/index.rst

+   :caption: Contents:
+
+   /general/abstract_models
+


remove 2 blank lines please

nemesifier · 2017-06-30T09:40:04Z

docs/source/general/abstract_models.rst

+   from model_utils.fields import AutoCreatedField, AutoLastModifiedField
+
+   class TimeStampedEditableModel(models.Model):
+     """


indentation of the docstring doesn't look right

coveralls · 2017-06-30T13:07:19Z

Coverage remained the same at 100.0% when pulling 52b5863 on freeradius_documentation into cfc018c on master.

coveralls · 2017-06-30T13:58:24Z

Coverage remained the same at 100.0% when pulling 29082a5 on freeradius_documentation into cfc018c on master.

nemesifier

👍 @yakky ok for me!

coveralls · 2017-07-04T12:59:39Z

Coverage remained the same at 100.0% when pulling 22665fd on freeradius_documentation into cfc018c on master.

coveralls · 2017-07-04T13:26:08Z

Coverage remained the same at 100.0% when pulling 9b48cb5 on freeradius_documentation into cfc018c on master.

coveralls · 2017-07-04T14:12:47Z

Coverage remained the same at 100.0% when pulling 8153f6c on freeradius_documentation into cfc018c on master.

lillopaco requested review from yakky and nemesifier June 29, 2017 19:03

yakky added this to the [GSoC 17] First evaluation milestone Jun 29, 2017

nemesifier suggested changes Jun 30, 2017

View reviewed changes

[docs] Added abstract model documentation

29082a5

lillopaco force-pushed the freeradius_documentation branch from 52b5863 to 29082a5 Compare June 30, 2017 13:53

nemesifier approved these changes Jun 30, 2017

View reviewed changes

lillopaco added 2 commits July 4, 2017 14:11

[documentation] added sphinx-build

22665fd

[sphinx-build] added permissions

9b48cb5

[docs] correct conf.py

8153f6c

yakky merged commit 287b427 into master Jul 4, 2017

nemesifier deleted the freeradius_documentation branch July 6, 2017 08:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Freeradius documentation #20

Freeradius documentation #20

lillopaco commented Jun 29, 2017

coveralls commented Jun 29, 2017 •

edited

nemesifier left a comment

nemesifier Jun 30, 2017 •

edited

nemesifier Jun 30, 2017

nemesifier Jun 30, 2017 •

edited

coveralls commented Jun 30, 2017 •

edited

coveralls commented Jun 30, 2017 •

edited

nemesifier left a comment

coveralls commented Jul 4, 2017 •

edited

coveralls commented Jul 4, 2017 •

edited

coveralls commented Jul 4, 2017 •

edited

Freeradius documentation #20

Freeradius documentation #20

Conversation

lillopaco commented Jun 29, 2017

coveralls commented Jun 29, 2017 • edited

nemesifier left a comment

Choose a reason for hiding this comment

nemesifier Jun 30, 2017 • edited

Choose a reason for hiding this comment

nemesifier Jun 30, 2017

Choose a reason for hiding this comment

nemesifier Jun 30, 2017 • edited

Choose a reason for hiding this comment

coveralls commented Jun 30, 2017 • edited

coveralls commented Jun 30, 2017 • edited

nemesifier left a comment

Choose a reason for hiding this comment

coveralls commented Jul 4, 2017 • edited

coveralls commented Jul 4, 2017 • edited

coveralls commented Jul 4, 2017 • edited

coveralls commented Jun 29, 2017 •

edited

nemesifier Jun 30, 2017 •

edited

nemesifier Jun 30, 2017 •

edited

coveralls commented Jun 30, 2017 •

edited

coveralls commented Jun 30, 2017 •

edited

coveralls commented Jul 4, 2017 •

edited

coveralls commented Jul 4, 2017 •

edited

coveralls commented Jul 4, 2017 •

edited