This repository has been archived by the owner on May 19, 2020. It is now read-only.
[admin] Added search fields and list displays #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
suggested changes
Jul 19, 2018
django_ipam/base/admin.py
Outdated
| @@ -22,6 +22,8 @@ class AbstractSubnetAdmin(TimeReadonlyAdminMixin, ModelAdmin): | |||
| change_form_template = "admin/django-ipam/subnet/change_form.html" | |||
| change_list_template = "admin/django-ipam/subnet/change_list.html" | |||
| app_name = "django_ipam" | |||
| list_display = ('subnet', 'name', 'master_subnet', 'description') | |||
There was a problem hiding this comment.
I think we should show the name first, because different subnets are assigned to different areas of the networks which are used for different purposes and humans recognize names more easily than ip address ranges.
django_ipam/base/admin.py
Outdated
| @@ -22,6 +22,8 @@ class AbstractSubnetAdmin(TimeReadonlyAdminMixin, ModelAdmin): | |||
| change_form_template = "admin/django-ipam/subnet/change_form.html" | |||
| change_list_template = "admin/django-ipam/subnet/change_list.html" | |||
| app_name = "django_ipam" | |||
| list_display = ('subnet', 'name', 'master_subnet', 'description') | |||
| search_fields = ['subnet', 'name'] | |||
There was a problem hiding this comment.
One question: does name have db_index=True in the model? If not please add it, it will speed up the search;
it makes sense to search by name so adding a database index is a very reasonable choice.
Do this change in a new commit on this same PR please.
Implements and closes #17
nemesifier
approved these changes
Jul 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements and closes #17