This repository has been archived by the owner on May 19, 2020. It is now read-only.
[models] NetworkField: fix conversion of None values #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okraits
force-pushed
the
tdt-fix-networkfield-conversion
branch
2 times, most recently
from
aadbcf1
to
97ee7a3
Compare
nemesifier
reviewed
Feb 5, 2020
There was a problem hiding this comment.
@okraits could you modify the first line of the commit message as follows please?
[models] NetworkField: Fix conversion of None values #94
97ee7a3
to
2c44ccf
Compare
okraits
force-pushed
the
tdt-fix-networkfield-conversion
branch
from
2c44ccf
to
2a265a1
Compare
Pull Request Test Coverage Report for Build 361
💛 - Coveralls |
Pull Request Test Coverage Report for Build 362
💛 - Coveralls |
|
@nemesisdesign Should I add a test for that? |
nemesifier
reviewed
Feb 5, 2020
I will try to come up with a test later today. |
nemesifier
approved these changes
Feb 6, 2020
|
I'm merging since it's just one line but if you do find a way to test please send it |
|
Ok - I just don't have the time to look into this now 😢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94