Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixed failing of indoor location test in openwisp-controller #114

Merged

Conversation

Aryamanz29
Copy link
Member

@Aryamanz29 Aryamanz29 commented Apr 19, 2023

Fixed a failing indoor location test in the 'geo' app of openwisp-controller by modifying the filter_url to consider the app_label during execution. Previously, the test 'test_floorplan_add_view_filters_indoor_location' was failing due to a hardcoded filter_url.

Screenshot from 2023-04-19 20-27-32

Fixed a failing indoor location test in the 'geo' app of openwisp-controller
by modifying the filter_url to consider the app_label during execution.
Previously, the test 'test_floorplan_add_view_filters_indoor_location'
was failing due to a hardcoded filter_url.
@Aryamanz29 Aryamanz29 force-pushed the fix-openwisp-controller-indoor-location-test-assertion branch from cb4de08 to 4411bd5 Compare April 19, 2023 14:50
@Aryamanz29 Aryamanz29 changed the title [Fix] Fixed failing of indoor location test in openwisp-controller [fix] Fixed failing of indoor location test in openwisp-controller Apr 19, 2023
@Aryamanz29 Aryamanz29 self-assigned this Apr 19, 2023
@Aryamanz29 Aryamanz29 marked this pull request as ready for review April 19, 2023 14:59
@nemesifier nemesifier merged commit 2f36fca into master Apr 19, 2023
12 checks passed
@nemesifier nemesifier deleted the fix-openwisp-controller-indoor-location-test-assertion branch April 19, 2023 15:32
@coveralls
Copy link

Coverage Status

Coverage: 99.799%. Remained the same when pulling cb4de08 on fix-openwisp-controller-indoor-location-test-assertion into 634e64c on master.

@coveralls
Copy link

Coverage Status

Coverage: 99.799%. Remained the same when pulling 4411bd5 on fix-openwisp-controller-indoor-location-test-assertion into 634e64c on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants