[controller] Add views to update general device information #164
Conversation
| @@ -132,6 +135,9 @@ def get_controller_urls(views_module): | |||
| url(r'^controller/download-config/(?P<pk>[^/]+)/$', | |||
| views_module.device_download_config, | |||
| name='download_config_legacy'), | |||
| url(r'^controller/update-info/(?P<pk>[^/]+)/$', | |||
| views_module.device_update_info, | |||
| name='update_info_legacy'), | |||
There was a problem hiding this comment.
we can avoid the legacy URL since this is a new URL
There was a problem hiding this comment.
I am a little bit irritated because here it only works with the legacy URL ^controller/update-info/(?P<pk>[^/]+)/$. And in openwisp-config the URL is also $BASEURL/update-info/$UUID/ with $BASEURL being $URL/controller.
What am I missing?
There was a problem hiding this comment.
you're right, we haven't updated openwisp-config to use the new URLs yet, so please go ahead and put the legacy URL back since it seems we need it right now (the patch in openwisp-config is also using that one right?)
There was a problem hiding this comment.
Yes, openwisp-config uses only URLs like ^controller/<api-endpoint>/ and not URLs like ^controller/device/<api-endpoint>/.
See:
https://github.com/openwisp/openwisp-config/blob/master/openwisp-config/files/openwisp.agent#L73
https://github.com/openwisp/openwisp-config/blob/master/openwisp-config/files/openwisp.agent#L585
So we will need to keep the legacy URLs for quite some time, otherwise older clients won't be able to connect to an updated server anymore.
I re-added the legacy URL.
okraits
force-pushed
the
tdt-update-device-info
branch
2 times, most recently
from
c1470f2
to
f0012d6
Compare
okraits
force-pushed
the
tdt-update-device-info
branch
from
f0012d6
to
fbead12
Compare
Fixed that and added tests. This is done from my side. |
okraits
changed the title
okraits
force-pushed
the
tdt-update-device-info
branch
from
fbead12
to
94c27d3
Compare
okraits
force-pushed
the
tdt-update-device-info
branch
from
94c27d3
to
cdef54a
Compare
nemesifier
added this to In progress
in OpenWISP Priorities for next releases
via automation
|
@nemesisdesign Please review this PR and the related ones for |
There was a problem hiding this comment.
@okraits on the code side It looks good, please give me some more time to test the changes in the 3 different modules (including openwisp-config) in my test env. This feature will go in the next release.
|
@nemesisdesign No problem, I have a week off from work now anyway. |
No description provided.