Improved config validation

[NoumbissiValere]

No description provided.

[coveralls]

Coverage increased (+0.0008%) to 99.915% when pulling abbd235 on improved-config-validation into ff7065f on master.

[nemesifier]

First impression looks good, I will test it asap.
In the meanwhile, please can you reduce the number of commits? I think one commit would be enough for this set of changes.

[NoumbissiValere]

ok @nemesisdesign I will squash the commits

[NoumbissiValere]

@nemesisdesign This PR looks ready. sorry for the delay

[atb00ker]

Two questions regarding this pull request below:

[atb00ker]

@NoumbissiValere

This issue was caused by https://github.com/openwisp/django-netjsonconfig/blob/master/django_netjsonconfig/base/template.py#L133
I removed it and replaced it with

This doesn't solve the problem though, It just ignores the variable! :-(
I think this needs to be handled at the time of save, I'll look into it as well! 😄

    def get_context(self):
        context = copy(self.default_values) or {}
        context.update(super().get_context())
        return context

solved it.

P.P.S: @NoumbissiValere can you please rebase to upstream/improved-config-validation before pushing! 😄

[NoumbissiValere]

Sure 😄 I will do further testing to make sure everything is ok with the changes I made and push

[atb00ker]

@nemesisdesign
Validation acts weirdly 1 & Validation acts weirdly 2 happens because the default values json used was not valid, which brings an issue that the user should be informed when the json is not valid, worked on that! 😄

[NoumbissiValere]

@nemesisdesign
Validation acts weirdly 1 & Validation acts weirdly 2 happens because the default values json used was not valid, which brings an issue that the user should be informed when the json is not valid, worked on that!

@atb00ker the validation acts weirdly 2 doesn't depend on the default_values json it is a functionality which should work even without the default values. I have tested thoroughly but could still see the error hints. so we still need to look into that

[NoumbissiValere]

@atb00ker Please when you have time, could you test that error hints are displayed when you inside a buggy template in advanced mode? I don't see anything but inspecting shows they are there. this happens on my browser across other modules which uses django-netjsonconfig. below is a screenshot of the output i get from openwisp-controller which is thesame with the output i get from this branch on django-netjsonconfig.

I don't know if the error is because of my browser or it is a general problem. could you test it and give me feedback? thanks 😄

[atb00ker]

Not sure why it isn't shown on your end, on my end it's working as expected. (Can you try refreshing your browser cache?)

[NoumbissiValere]

I had not only refresh but also did a hard reload. But since it's working on your end it's ok. I will work on my browser. Thank you for taking our time to test @atb00ker 😊
@nemesisdesign could you review it now? All the changes requested have been done.

[atb00ker]

@NoumbissiValere
Should we move the focus of this line from bypass validation to allows setting variable; i.e from user's perspective?

P.S: I removed some changes that I made wouldn't required now. Please rebase again. 😄

[NoumbissiValere]

Ok @atb00ker 😄

[nemesifier]

Great work @NoumbissiValere and thank you @atb00ker for your review and support.
This is what I call team work! 👍 💪

Finally merging this! 🎉 🎉
Thank you for your patience and persitence! 🙏