New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Avoid default_app_config Deprecation Warning in Django >= 3.2 #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :) |
please check the build failures |
Please read our guidelines at: http://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to change the commit format
994aaf8
to
e9111aa
Compare
ok tried my best :) |
Django 3.2 started throwing deprecation warnings about the use of default_app_config in modules' __init__.py. The practice will start throwing errors in Django 4.1. This precludes future problems by only including the code if the Django version is below 3.2.
e9111aa
to
ecbc2b0
Compare
I had to fixed a merge conflict, can you please pull & run flake8 check and push again? |
7b4434f
to
ee39b3a
Compare
Your commit message does not follow our commit message style guidelines:
Please read our guidelines at: http://openwisp.io/docs/developer/contributing.html#commit-message-style-guidelines [fix] flake8 formatting |
ee39b3a
to
c44c520
Compare
strange, it was green in the PR & showing failure after merge! |
Not sure why. The QA checks seem very strict for this project. Not necessarily a bad thing, but it looks like it thinks I've mentioned a particular issue (I didn't) and is angry at me for not mentioning that it is fixed in this PR. At least the code should work fine. |
The problem was fixed in #270 and it was not a strictly QA check issue as far as I understood. |
Would it be possible to have a minor release with this fix? 🙏 |
This will stop Django 3.2 and higher from raising Deprecation Warnings because default_app_config is no longer necessary and will be removed in 4.1. Note that it breaks backward incompatibility with Django < 3.2 so it should only be used in releases dropping <3.2 support.
Yes, It may be a bit early for this one :)