[feat] add support for dist parameter on DistanceToPointOrderingFilter
#274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Apr 4, 2022
| @@ -4,3 +4,5 @@ contexttimer | |||
| # QA checks | |||
| openwisp-utils[qa]~=0.7.0 | |||
| packaging~=20.4 | |||
| coreapi==2.3.3 | |||
There was a problem hiding this comment.
coreapi is planned to be deprecated
There was a problem hiding this comment.
@auvipy great point, thanks for pointing that out! Do you have suggestions about the best way to handle this?
| py==1.11.0 | ||
| pycodestyle==2.8.0 | ||
| pyparsing==3.0.7 | ||
| six==1.16.0 |
| toml==0.10.2 | ||
| tox==3.24.5 | ||
| virtualenv==20.13.4 | ||
| coreapi==2.3.3 |
There was a problem hiding this comment.
coreapi is scheduled to be deprecated
nemesifier
force-pushed
the
master
branch
2 times, most recently
from
d137601
to
f2dc812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DistanceToPointOrderingFilterinherits from theDistanceToPointFilterbut only supports thepointparam and nodistparam. This adds support for thedistparam (such that a user can query for all points within a certaindistof the givenpointand have the results returned inascordescorder) by combining thefilter_querysetlogic of the existingDistanceToPointOrderingFilter#filter_querysetand theDistanceToPointFilter#filter_queryset.This also implements a
get_schema_fields()method so the filter fields can be included in schema autogeneration provided by the Django REST framework (documentation linked)