Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check library against django 4.1/4.2 #287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gbip
Copy link
Contributor

@gbip gbip commented Oct 18, 2023

No description provided.

@gbip
Copy link
Contributor Author

gbip commented Oct 19, 2023

I have ran the tests localy with -Wa for python3.11, django 4.2 and drf 3.14 => no issues except the one solved by #288 which is unrelated to those version upgrades.

@gbip gbip marked this pull request as ready for review October 19, 2023 08:18
@auvipy auvipy self-requested a review October 20, 2023 13:05
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase on /merge with the latest master?

@gbip gbip force-pushed the upgrade_django branch 3 times, most recently from bf47aa2 to e9d22c0 Compare November 2, 2023 08:21
@gbip
Copy link
Contributor Author

gbip commented Nov 2, 2023

Could you please rebase on /merge with the latest master?

Done.

Some tests are failing (django v3.0 and v4.2), it seems that it's an old psycopg2 bug : psycopg/psycopg2#1293

I had to remove the version constraint on psycopg2 because pip could not resolve the dependency graph for django 4.2.
Also, there seems to be a dependency issue for newer version of django.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants