[change] Updated common_name max_length to 64 #99

Closes #99

django_x509/base/models.py

@@ -141,7 +141,7 @@ class BaseX509(models.Model):
         _('organizational unit name'), max_length=64, blank=True
     )
     email = models.EmailField(_('email address'), blank=True)
-    common_name = models.CharField(_('common name'), max_length=63, blank=True)
+    common_name = models.CharField(_('common name'), max_length=64, blank=True)
     extensions = JSONField(
         _('extensions'),
         default=list,

django_x509/migrations/0008_common_name_max_length.py

@@ -0,0 +1,27 @@
+# Generated by Django 3.0.4 on 2020-09-09 07:41
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('django_x509', '0007_serial_number_max_length'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='ca',
+            name='common_name',
+            field=models.CharField(
+                blank=True, max_length=64, verbose_name='common name'
+            ),
+        ),
+        migrations.AlterField(
+            model_name='cert',
+            name='common_name',
+            field=models.CharField(
+                blank=True, max_length=64, verbose_name='common name'
+            ),
+        ),
+    ]

django_x509/tests/test_ca.py

@@ -666,3 +666,16 @@ def test_renew(self):
         self.assertNotEqual(old_cert2_key, cert2.private_key)
         self.assertLess(old_cert2_end, cert2.validity_end)
         self.assertNotEqual(old_cert2_serial_number, cert2.serial_number)
+
+    def test_ca_common_name_length(self):
+        common_name = (
+            'this is a very very very very very very'
+            ' very very very very very very long name'
+        )
+        with self.assertRaises(ValidationError) as context_manager:
+            self._create_ca(common_name=common_name)
+
+        msg = 'Ensure this value has at most 64 characters'
+        message_dict = context_manager.exception.message_dict
+        self.assertIn('common_name', message_dict)
+        self.assertIn(msg, message_dict['common_name'][0])

django_x509/tests/test_cert.py

@@ -525,3 +525,16 @@ def test_renew(self):
         self.assertEqual(old_ca_key, cert.ca.private_key)
         self.assertEqual(old_ca_end, cert.ca.validity_end)
         self.assertEqual(old_ca_serial_number, cert.ca.serial_number)
+
+    def test_cert_common_name_length(self):
+        common_name = (
+            'this is a very very very very very very'
+            ' very very very very very very long name'
+        )
+        with self.assertRaises(ValidationError) as context_manager:
+            self._create_cert(common_name=common_name)
+
+        msg = 'Ensure this value has at most 64 characters'
+        message_dict = context_manager.exception.message_dict
+        self.assertIn('common_name', message_dict)
+        self.assertIn(msg, message_dict['common_name'][0])

tests/openwisp2/sample_x509/migrations/0002_common_name_max_length.py

@@ -0,0 +1,34 @@
+# Generated by Django 3.1.1 on 2020-09-09 08:21
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('sample_x509', '0001_initial'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='ca',
+            name='common_name',
+            field=models.CharField(
+                blank=True, max_length=64, verbose_name='common name'
+            ),
+        ),
+        migrations.AlterField(
+            model_name='cert',
+            name='common_name',
+            field=models.CharField(
+                blank=True, max_length=64, verbose_name='common name'
+            ),
+        ),
+        migrations.AlterField(
+            model_name='customcert',
+            name='common_name',
+            field=models.CharField(
+                blank=True, max_length=64, verbose_name='common name'
+            ),
+        ),
+    ]