[fix] Fixed render issue in popup page #113 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atb00ker
approved these changes
Apr 6, 2021
OpenWISP Priorities for next releases
automation
moved this from In progress
to Reviewer approved
Apr 6, 2021
atb00ker
requested changes
Apr 6, 2021
OpenWISP Priorities for next releases
automation
moved this from Reviewer approved
to In progress
Apr 6, 2021
nemesifier
requested changes
Apr 6, 2021
There was a problem hiding this comment.
Wait, noticed a problem, when I try to create a new CA from from certificate's add form, I don't get the option to select if I want create new or import.
This change should only affect the change page! smile
Definitely.
@niteshsinha17 please spend time testing that your changes do not affect negatively the existing features.
@atb00ker Thanks for spotting this. I have fixed it. Please check. |
niteshsinha17
moved this from In progress
to Ready for review/testing
in OpenWISP Priorities for next releases
nemesifier
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Thanks @niteshsinha17 and @atb00ker for your precious review & testing 👍
OpenWISP Priorities for next releases
automation
moved this from Ready for review/testing
to Done
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nemesisdesign Before writing tests I wanted to show the implementation. Is it ok? I will need to use selenium in the test.
closes #113