Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Bumped "openwisp-utils~=1.0.5"" #139

Closed
wants to merge 1 commit into from

Conversation

jchaloupka007
Copy link
Contributor

@jchaloupka007 jchaloupka007 commented Feb 22, 2024

Missed this in the previous PR, since the breaking package was PyOpenSSL, I did not check that it was also a dependency of openwisp-utils. Apologies for the oversight resulting in multiple PR's.

Changed

  • Bumped "openwisp-utils~=1.0.5".

@coveralls
Copy link

Coverage Status

coverage: 99.287%. remained the same
when pulling fcc222a on jchaloupka007:bump-openwisp
into b9699e8 on openwisp:master.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what's the need of this?
What does this fix?

We point to the main dev branch during development, we switch to stable releases only when releasing.

@jchaloupka007
Copy link
Contributor Author

jchaloupka007 commented Feb 26, 2024

My apologies, the openwisp-utils package that is currently in the requirements on the master branch seems to be incompatible with M1 macs due to a dependency it has on PyOpenSSL, and I was simply aiming to fix that.
As for opening this to the wrong branch, I apologize, I couldn't find the dev branch, and after reading through the branch naming conventions on the contributing guidelines, where it shows an example pushing to master, I assumed that that was what I was supposed to do.

This package has not received updates on pypi in over a year, and the version of the “cryptography” package required in 1.1, contains known security vulnerabilities.
This package is widely used, therefore I think that this should be addressed, at least in a patch. If the way I am proposing it in this (and the previous) PR is incorrect, please do cancel it and revert the previous PR if needed,
But a patch with updated dependencies to this package would be amazing.
Sorry if I caused any inconvenience, and thank you very much.

@jchaloupka007 jchaloupka007 deleted the bump-openwisp branch March 26, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants