Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add on_delete with CASCADE on Ca ForeignKey #2

Merged
merged 1 commit into from
Jun 16, 2017
Merged

add on_delete with CASCADE on Ca ForeignKey #2

merged 1 commit into from
Jun 16, 2017

Conversation

hggh
Copy link
Contributor

@hggh hggh commented Jun 14, 2017

RemovedInDjango20Warning: on_delete will be a required arg

add on_delete with CASCADE on Ca ForeignKey
f6d398c 
RemovedInDjango20Warning: on_delete will be a required arg
@coveralls
Copy link

coveralls commented Jun 14, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 93.631% when pulling f6d398c on hggh:feature/django20 into 4788142 on openwisp:master.

@nemesifier
Copy link
Member

nemesifier commented Jun 14, 2017 •
edited
Loading

@hggh thank you for contributing. Shouldn't a migration be created as well?

Eg:

cd tests
./manage.py makemigrations

You could then amend your commit and push --force to your development branch to update this pull request.

@nemesifier nemesifier self-assigned this Jun 14, 2017
@nemesifier nemesifier merged commit f6d398c into openwisp:master Jun 16, 2017
@nemesifier
Copy link
Member

@hggh I was wrong, sorry! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nemesifier nemesifier

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hggh @coveralls @nemesifier