Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enchancement] Add firmware-upgrader image #138 #150

Merged
merged 1 commit into from Jun 28, 2021
Merged

[enchancement] Add firmware-upgrader image #138 #150

merged 1 commit into from Jun 28, 2021

Conversation

atb00ker
Copy link
Member

@atb00ker atb00ker commented Mar 25, 2021 •
edited

Closes #138

@atb00ker atb00ker marked this pull request as draft March 25, 2021 20:17
@atb00ker atb00ker self-assigned this Mar 25, 2021
@atb00ker atb00ker added the enhancement New feature or request label Mar 25, 2021
@atb00ker atb00ker force-pushed the firmware branch 11 times, most recently from 45a842d to c7dd0d9 Compare March 27, 2021 20:41
@atb00ker atb00ker marked this pull request as ready for review March 28, 2021 16:55
nemesifier
nemesifier reviewed Apr 6, 2021
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atb00ker I am not sure it's worth it to deploy the firmware upgrader in a dedicated container because it's not used nor called so often like the controller HTTP views or the monitoring views.

What about including it in the controller container? It should make sense.

@atb00ker
Copy link
Member Author

atb00ker commented Apr 6, 2021

What about including it in the controller container? It should make sense.

Okay, Do you mean the dashboard image? Controller image is just the controller API! 😄

@atb00ker atb00ker force-pushed the firmware branch 2 times, most recently from d48576c to 970eaf6 Compare April 17, 2021 17:44
@atb00ker
Copy link
Member Author

Okay, Do you mean the dashboard image? Controller image is just the controller API! smile

Added in the dashboard container.

@atb00ker atb00ker added this to To do (general) in OpenWISP Contributor's Board via automation Apr 18, 2021
@atb00ker
Copy link
Member Author

atb00ker commented Apr 27, 2021 •
edited

Changing approach:

- openwisp-dasboard             - Admin UI
- openwisp-radius               - Just radius API
- openwisp-api        - controller,  fw-upgrader, monitor, network-topology API

@atb00ker atb00ker changed the title [enchancement] Add firmware-upgrader image [enchancement] Add firmware-upgrader image #138 May 17, 2021
@atb00ker atb00ker force-pushed the firmware branch 6 times, most recently from 4858f1f to 481fbdc Compare May 22, 2021 12:16
@atb00ker atb00ker force-pushed the firmware branch 2 times, most recently from c4a0658 to 51126f6 Compare May 25, 2021 18:58
@atb00ker atb00ker merged commit 8c20a74 into openwisp:master Jun 28, 2021
OpenWISP Contributor's Board automation moved this from To do (general) to Done Jun 28, 2021
@atb00ker atb00ker deleted the firmware branch June 28, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier left review comments

Assignees

@atb00ker atb00ker

Labels
enhancement New feature or request
Projects
OpenWISP Contributor's Board
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[module] Add firmware-upgrader module
2 participants
@atb00ker @nemesifier