[change] Show element info on hover

closes #130
openwisp · Jun 13, 2022 · 1e42aa0 · 1e42aa0
1 parent 7139b21
commit 1e42aa0
Showing 1 changed file with 27 additions and 28 deletions.
diff --git a/src/js/netjsongraph.render.js b/src/js/netjsongraph.render.js
@@ -27,40 +27,39 @@ class NetJSONGraphRender {
    *
    */
   echartsSetOption(customOption, _this) {
-    const configs = _this.config;
-    const echartsLayer = _this.echarts;
-    const commonOption = _this.utils.deepMergeObj(
-      {
-        // Show element's detail when hover
-        //
-        // tooltip: {
-        //   confine: true,
-        //   formatter: params => {
-        //     if (params.componentSubType === "graph") {
-        //       return params.dataType === "edge"
-        //         ? _this.utils.linkInfo(params.data)
-        //         : _this.utils.nodeInfo(params.data);
-        //     } else if (params.componentSubType === "graphGL") {
-        //       return _this.utils.nodeInfo(params.data);
-        //     } else {
-        //       return params.componentSubType === "lines"
-        //         ? _this.utils.linkInfo(params.data.link)
-        //         : _this.utils.nodeInfo(params.data.node);
-        //     }
-        //   }
-        // }
-      },
-      configs.echartsOption,
-    );
+    const configs = _this.config,
+      echartsLayer = _this.echarts,
+      commonOption = _this.utils.deepMergeObj(
+        {
+          // Show element's detail when hover
+
+          tooltip: {
+            confine: true,
+            formatter: (params) => {
+              if (params.componentSubType === "graph") {
+                return params.dataType === "edge"
+                  ? _this.utils.linkInfo(params.data)
+                  : _this.utils.nodeInfo(params.data);
+              } else if (params.componentSubType === "graphGL") {
+                return _this.utils.nodeInfo(params.data);
+              } else {
+                return params.componentSubType === "lines"
+                  ? _this.utils.linkInfo(params.data.link)
+                  : _this.utils.nodeInfo(params.data.node);
+              }
+            },
+          },
+        },
+        configs.echartsOption,
+      );
 
     echartsLayer.setOption(
       _this.utils.deepMergeObj(commonOption, customOption),
     );
     echartsLayer.on(
       "click",
-      // eslint-disable-next-line consistent-return
-      (params) => {
-        const clickElement = configs.onClickElement.bind(_this);
+      function (params) {
+        let clickElement = configs.onClickElement.bind(_this);
 
         if (params.componentSubType === "graph") {
           clickElement(