Merge b49cb21 into 2bec5a3

openwisp · Jul 29, 2022 · cb97b06 · cb97b06
2 parents 2bec5a3 + b49cb21
commit cb97b06
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 9 deletions.
diff --git a/dist/netjsongraph.min.js b/dist/netjsongraph.min.js
diff --git a/examples/netjsongraph-elementsLegend.html b/examples/netjsongraph-elementsLegend.html
@@ -88,7 +88,7 @@ <h4>Legends</h4>
             The demo is used to show how to set colorful nodes.
         */
       const graph = new NetJSONGraph("./data/netjson-elementsLegend.json", {
-        el: "container",
+        el: "#container",
         graphConfig: {
           series: {
             force: {

diff --git a/examples/realtime_update/assets/netjsongraph.min.js b/examples/realtime_update/assets/netjsongraph.min.js
diff --git a/src/js/netjsongraph.core.js b/src/js/netjsongraph.core.js
@@ -34,7 +34,7 @@ class NetJSONGraph {
       } else if (this.utils.isElement(this.config.el)) {
         this.el = this.config.el;
       } else {
-        this.el = document.getElementById(this.config.el);
+        this.el = document.querySelector(this.config.el);
       }
       if (this.el === document.body) {
         this.el.classList.add("njg-relativePosition");

diff --git a/src/js/netjsongraph.gui.js b/src/js/netjsongraph.gui.js
@@ -28,15 +28,13 @@ class NetJSONGraphGUI {
   createSideBar() {
     const sideBar = document.createElement("div");
     sideBar.setAttribute("class", "njg-sideBar");
-    const {body} = document;
     const button = document.createElement("button");
     sideBar.appendChild(button);
-
     button.classList.add("sideBarHandle");
     button.onclick = () => {
       sideBar.classList.toggle("hidden");
     };
-    body.appendChild(sideBar);
+    this.self.el.appendChild(sideBar);
     return sideBar;
   }
 

diff --git a/test/netjsongraph.render.test.js b/test/netjsongraph.render.test.js
@@ -89,13 +89,13 @@ describe("Test netjsongraph setConfig", () => {
     container.setAttribute("id", "container");
     const obj4 = new NetJSONGraph([JSONFILE, JSONFILE]);
     obj4.setConfig({
-      el: "container",
+      el: "#container",
     });
     expect(obj4.el).toBe(container);
     document.body.removeChild(container);
 
     obj1.setConfig({
-      el: "container",
+      el: "#container",
     });
     expect(obj1.el).toBe(document.body);
   });