Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Show element info on hover #130 #131

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

totallynotvaishnav
Copy link
Member

closes #130

@totallynotvaishnav totallynotvaishnav added this to In progress in [GSoC 22] netjsongraph.js via automation Jun 11, 2022
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on latest master and fix conflicts.

[GSoC 22] netjsongraph.js automation moved this from In progress to Review in progress Jun 13, 2022
@totallynotvaishnav
Copy link
Member Author

on it.

@totallynotvaishnav totallynotvaishnav force-pushed the issues/130-show-info-on-hover branch 3 times, most recently from f6a8bce to 22797d8 Compare June 13, 2022 19:18
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, can we make it look better?

Screenshot from 2022-06-14 19-23-21

I think the default lateral padding of the tooltip should be increased.
I would also try to show the tooltip slightly closer to the object, what do you think?
Any other idea to make it look slicker?

@totallynotvaishnav
Copy link
Member Author

I would also try to show the tooltip slightly closer to the object, what do you think?

I agree it should be more closer to the element. I'm working on it.

Any other idea to make it look slicker?

I will share if I find something better.

@totallynotvaishnav
Copy link
Member Author

Screenshot

Screenshot 2022-06-16 at 11 21 07 PM

@nemesisdesign There is a new option to set class name in version 5 of echarts. We can customize the tooltip styling using css more easily. I think it would be nice to have an arrow that points towards the element.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress!

If I hover the mouse on a node which is closer to the right edge, the tooltip covers the node:

Screenshot from 2022-06-18 16-19-29

Isn't there a way to make the tooltip smart and position itself according to the edge of the window? Can it position itself on the left instead of the right in this situation?

@nemesifier nemesifier moved this from Review in progress to In progress in [GSoC 22] netjsongraph.js Jun 18, 2022
@totallynotvaishnav
Copy link
Member Author

Isn't there a way to make the tooltip smart and position itself according to the edge of the window? Can it position itself on the left instead of the right in this situation?

I believe it is possible. I will look into this and come up with a solution.

@totallynotvaishnav
Copy link
Member Author

Updated screenshot

Screenshot 2022-06-24 at 9 03 35 PM

[GSoC 22] netjsongraph.js automation moved this from In progress to Reviewer approved Jun 24, 2022
@nemesifier nemesifier merged commit c316f2f into gsoc22 Jun 24, 2022
[GSoC 22] netjsongraph.js automation moved this from Reviewer approved to Done Jun 24, 2022
@nemesifier nemesifier deleted the issues/130-show-info-on-hover branch June 24, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants