Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Hardware ID / serial number #70

Closed
nemesifier opened this issue Oct 3, 2018 · 5 comments
Closed

[feature] Hardware ID / serial number #70

nemesifier opened this issue Oct 3, 2018 · 5 comments
Assignees
Labels
enhancement important Higher priority or release blocker

Comments

@nemesifier
Copy link
Member

We should add a new configuration option like "serial_number" or "serial_number_script", which is a path to a script which if exists will be used to retrieve the serial number, which will then be sent to ow2 during registration.

We could add another boolean config option like "serial_number_key" which if true uses the serial number to generate the device key.
The default value of this config option could be true if "serial_number_script" is defined and exists, false otherwise.
It would basically mean the key is generated from the serial number by default when this feature is used, but it can be turned off if needed.

The actual names of the config options may be different than those proposed here if we find better ones.

@okraits
Copy link
Member

okraits commented Oct 4, 2018

I'm proposing hardware_id instead of serial_number as the common part in the names of the configuration options as it is more generic. I guess that anybody who wants to use that field for something else than a serial number would be irritated by that name.

@nemesifier
Copy link
Member Author

@okraits great, that's fine for me, we will just have to indicate both namings in the README to help users find this feature more quickly if they need it

@okraits
Copy link
Member

okraits commented Nov 7, 2018

@nemesisdesign I already updated README.md in #75 to explain the feature. Please check if the explanation is sufficient. Maybe it would make sense to add a link to the README.md of django-netjsonconfig for additional explanations?

@nemesifier
Copy link
Member Author

@okraits adding a link to the hardware-id README section of django-netjsonconfig is a great idea!

@okraits
Copy link
Member

okraits commented Nov 18, 2018

@nemesisdesign I rebased against master and added the link.

@nemesifier nemesifier added the important Higher priority or release blocker label Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement important Higher priority or release blocker
Projects
Archived in project
Development

No branches or pull requests

2 participants