Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Hardcoded paths to static files in JS code #660

Closed
nemesifier opened this issue Jun 17, 2022 · 0 comments · Fixed by #661
Closed

[bug] Hardcoded paths to static files in JS code #660

nemesifier opened this issue Jun 17, 2022 · 0 comments · Fixed by #661
Labels
bug

Comments

@nemesifier
Copy link
Member

These references to static files from JS code are hardcoded:
https://github.com/openwisp/openwisp-controller/search?q=%2Fadmin%2Fimg

They won't work when working with different static storage classes (eg: object storage for cloud systems).
@nemesifier nemesifier added the bug label Jun 17, 2022
codesankalp added a commit that referenced this issue Jun 17, 2022
@codesankalp
[Fix] Removed hardcoded static files from js files #660
110d746 
Fixes #660
@codesankalp codesankalp mentioned this issue Jun 17, 2022
Merged
codesankalp added a commit that referenced this issue Jun 20, 2022
@codesankalp
[Fix] Removed hardcoded static files from js files #660
4b94df8 
Fixes #660
nemesifier pushed a commit that referenced this issue Jun 23, 2022
@codesankalp
[fix] Removed hardcoded static files from js files #660
1205d85 
Fixes #660
nemesifier added a commit that referenced this issue Jun 23, 2022
@nemesifier
[fix] Removed hardcoded static files from js files #660
9bcba3d 
Fixes #660
@pandafy pandafy mentioned this issue Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Removed hardcoded static files from js files #660 openwisp/openwisp-controller
1 participant
@nemesifier