Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Checksum cache is not invalidated on VPN server change #667

Closed
nemesifier opened this issue Jul 1, 2022 · 0 comments · Fixed by #674
Closed

[bug] Checksum cache is not invalidated on VPN server change #667

nemesifier opened this issue Jul 1, 2022 · 0 comments · Fixed by #674

Comments

@nemesifier
Copy link
Member

If a VPN server is changed, there could be some variables (eg: hostname), which may be used in the VPN-client templates and would need to invalidate the cache of all the devices using those templates, but this is not being done now.

The result is that the config checksum is outdated and devices do not update their config.

To fix this we shall do the following:

  • when a VPN server is changed, launch a celery background task
  • the task shall call a method on the VPN server model which triggers invalidation
  • the method shall look for any vpn client template related to the VPN server, then find all the devices which have the template and invalidate the cache for them
@nemesifier nemesifier added the bug label Jul 1, 2022
@nemesifier nemesifier added this to Backlog in OpenWISP Priorities for next releases via automation Jul 1, 2022
@nemesifier nemesifier added this to To do (general) in OpenWISP Contributor's Board via automation Jul 1, 2022
OpenWISP Contributor's Board automation moved this from To do (general) to Done Jul 14, 2022
OpenWISP Priorities for next releases automation moved this from Backlog to Done Jul 14, 2022
pandafy pushed a commit that referenced this issue Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant