[chores] UX: added loading indicator when VPN server is created #227 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
added this to In progress
in OpenWISP Priorities for next releases
via automation
atb00ker
reviewed
Jul 8, 2020
| spinner.fadeOut(250, function () { | ||
| var message = gettext( | ||
| 'Please be patient, we are creating all the necessary ' + | ||
| 'cyrptographic keys which may take a minute or two ...' |
There was a problem hiding this comment.
Also, vscode wants to change indentation of this line. :-P
There was a problem hiding this comment.
jslinter is complaining, maybe we can try switching to jshint
After 2.5 seconds a text which asks the user to wait is shown. We need this because generating the Diffie Helman of 2048 bits length takes considerable more time. Closes #227
nemesifier
force-pushed
the
227-vpn-creation-loading-indicator
branch
from
e739171
to
17820b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 2.5 seconds a text which asks the user to wait is shown.
We need this because generating the Diffie Helman of 2048 bits
length takes considerable more time.
Closes #227