Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chores] Update dependencies #252

Merged
merged 1 commit into from Aug 19, 2020
Merged

[chores] Update dependencies #252

merged 1 commit into from Aug 19, 2020

Conversation

atb00ker
Copy link
Member

No description provided.

Copy link
Member Author

@atb00ker atb00ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of whitespace changes because of isort, highlighted some changes below:

@@ -0,0 +1,18 @@
# Generated by Django 3.1 on 2020-08-18 11:34
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New migration.

@@ -180,7 +180,7 @@ class AbstractDeviceConnection(ConnectorMixin, TimeStampedEditableModel):
dump_kwargs={'indent': 4},
)
# usability improvements
is_working = models.NullBooleanField(default=None)
is_working = models.BooleanField(null=True, blank=True, default=None)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NullBooleanField is deprecated.

requirements.txt Show resolved Hide resolved
Comment on lines +211 to +212
DJANGO_X509_CA_MODEL = 'sample_pki.Ca'
DJANGO_X509_CERT_MODEL = 'sample_pki.Cert'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed PKI_CA_MODEL and PKI_CERT_MODEL variables.

@atb00ker atb00ker self-assigned this Aug 18, 2020
@atb00ker atb00ker added this to In progress in [GSoC20] Merge modules via automation Aug 18, 2020
@atb00ker atb00ker moved this from In progress to Open Pull-Requests in [GSoC20] Merge modules Aug 18, 2020
@atb00ker atb00ker moved this from Open Pull-Requests to Ready for review in [GSoC20] Merge modules Aug 18, 2020
@atb00ker atb00ker moved this from Ready for review to Open Pull-Requests in [GSoC20] Merge modules Aug 18, 2020
@coveralls
Copy link

coveralls commented Aug 19, 2020

Coverage Status

Coverage remained the same at 98.849% when pulling ee7f3fc on atb00ker:deps into 53cf1b6 on openwisp:master.

@atb00ker atb00ker moved this from Open Pull-Requests to Ready for review in [GSoC20] Merge modules Aug 19, 2020
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks, one doubt below

requirements.txt Outdated Show resolved Hide resolved
[GSoC20] Merge modules automation moved this from Ready for review to Open Pull-Requests Aug 19, 2020
@atb00ker atb00ker moved this from Open Pull-Requests to Ready for review in [GSoC20] Merge modules Aug 19, 2020
@atb00ker atb00ker moved this from Ready for review to Open Pull-Requests in [GSoC20] Merge modules Aug 19, 2020
@atb00ker atb00ker moved this from Open Pull-Requests to Ready for review in [GSoC20] Merge modules Aug 19, 2020
@nemesifier nemesifier merged commit f30fc2c into openwisp:master Aug 19, 2020
[GSoC20] Merge modules automation moved this from Ready for review to Done Aug 19, 2020
@atb00ker atb00ker deleted the deps branch August 21, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants