[chores] Fixed tests for sample_users #556
Conversation
- Minor changes to CI configuration to ensure correct version of Django in the Python environment.
pandafy
force-pushed
the
fix-sample-users-test
branch
from
d3161dc
to
a1e5653
Compare
There was a problem hiding this comment.
@pandafy can you please investigate why the build is failing due to some coverage/coveralls library issue?
|
We are affected by TheKevJames/coveralls-python#326 |
The pytest-cov lib doesn't cap the coverage version, breaking coveralls.
|
Unfortunately we need to add an explicit pin to coverage because of pytest-cov. No big deal. But it seems the latest version of openwisp-utils was not being used in tests, because some query tests fail. It seems less queries are executed now, which may be good. |
|
The number of queries are going down due to the recent changes done in openwisp-notifications. |
| @@ -441,6 +441,6 @@ def test_delete_deviceconnection_detail(self): | |||
| dc = self._create_device_connection() | |||
| d1 = dc.device.id | |||
| path = reverse('connection_api:deviceconnection_detail', args=(d1, dc.pk)) | |||
| with self.assertNumQueries(10): | |||
| with self.assertNumQueries(7): | |||
There was a problem hiding this comment.
I have made this change just for the sake of build to pass. We probably have to revert this in #558
There was a problem hiding this comment.
The number of queries are going down due to the recent changes done in openwisp-notifications.
Ah ok, thanks for clarifying!
I have made this change just for the sake of build to pass. We probably have to revert this in #558
No problem, let's do it.
of Django in the Python environment.