[feature] Added missing endpoints for DeviceFirmware and UpgradeOperation #206 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code adds four endpoints:
1. upgrade-operation/
- List all the upgrade operation in the system
2. upgrade-operation/<id>/
- Display detail of a particular upgrade id
3. device/<id>/upgrade-operation/
- return a list of upgrade-operation ids for a given device id
4. device/<id>/firmware/
- PUT: if DeviceFirmware doesn't exist, create a new object else
update the image of the DeviceFirmware. Returns
the DeviceFirmware object and if an upgrade operation
was created, also return the id of the UpgradeOperation
- GET: return the DeviceFirmware object
Closes #206
Aryamanz29
force-pushed
the
issue-206/add-missing-endpoints
branch
2 times, most recently
from
ff245c8
to
9a26cb0
Compare
nemesifier
reviewed
May 15, 2023
nemesifier
requested changes
May 16, 2023
There was a problem hiding this comment.
Here's some feedback from the first round of testing.
I did a quick test of the different endpoints which seem to work quite well.
Below I have some minor change requests.
Upgrade Operation List:
- can you allow to filter by org and org_slug?
- can you allow to filter by device ID (can we avoid generating the select with the entire device list in the UI to avoid this to fail on large instances?)
- allow filter by image ID (can we avoid generating the select with the entire image list in the UI to avoid this to fail on large instances?)
- allow filter by status
Device Upgrade Operation List:
- allow filter by status
I will do another round of acid testing and code review tomorrow.
- Added api filters tests.
- Additionally, included the missing mentions of API list filters for the following endpoints: build/, build/<build_id>/image, and batch-upgrade-operation/
Aryamanz29
force-pushed
the
issue-206/add-missing-endpoints
branch
from
5e8256a
to
86a3e8e
Compare
nemesifier
requested changes
May 24, 2023
- `ValidatedModelSerializer` is not required for read-only API views.
Aryamanz29
force-pushed
the
issue-206/add-missing-endpoints
branch
from
f922903
to
54f8d6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blockers
[chores] Use SeleniumTestMixin from openwisp-utils #234
[fix] Fixed related org field filtering in multitentant dj-filters openwisp-users#352
This PR adds four endpoints:
upgrade-operation/upgrade-operation/<id>/device/<device_pk>/upgrade-operation/device/<device_pk>/firmware/PUT: if DeviceFirmware doesn't exist, create a new object else
update the image of the DeviceFirmware.
Returns the DeviceFirmware object and if an upgrade operation
was created, also return the id of the UpgradeOperation.
GET: return the DeviceFirmware object,
Closes #206