Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] implement multitenant admin #10

Merged
merged 1 commit into from
Nov 25, 2018
Merged

[admin] implement multitenant admin #10

merged 1 commit into from
Nov 25, 2018

Conversation

shashwat1002
Copy link
Contributor

Implements multitenancy in admin and adds a test for the same.
and thereby Fixes #6

@coveralls
Copy link

coveralls commented Nov 24, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 16

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 98.0%
Totals Coverage Status
Change from base Build 13: 0.01%
Covered Lines: 147
Relevant Lines: 150
💛 - Coveralls

nemesifier
nemesifier approved these changes Nov 25, 2018
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

I really appreciate how you have been able to solve this task by reading the code of other modules and doing your own research. 👍

@nemesifier nemesifier merged commit b411073 into openwisp:master Nov 25, 2018
@shashwat1002
Copy link
Contributor Author

Thanks @nemesisdesign !

@shashwat1002 shashwat1002 deleted the implement_multitenancy_admin branch November 25, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shashwat1002 @coveralls @nemesifier