Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Excluded child subnets from overlapping validation #87 #100

Merged
merged 2 commits into from
May 17, 2021
Merged

[Fix] Excluded child subnets from overlapping validation #87 #100

merged 2 commits into from
May 17, 2021

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented May 14, 2021

Closes #87

@pandafy pandafy requested a review from nemesifier May 14, 2021 14:11
@pandafy pandafy self-assigned this May 14, 2021
@pandafy pandafy added this to In progress in OpenWISP Priorities for next releases via automation May 14, 2021
@pandafy pandafy added this to To do (general) in OpenWISP Contributor's Board via automation May 14, 2021
@pandafy pandafy moved this from To do (general) to Needs review in OpenWISP Contributor's Board May 14, 2021
@pandafy pandafy force-pushed the issues/87-master-subnet-validation branch 4 times, most recently from d8fbdf8 to 7a4a875 Compare May 14, 2021 14:49
@pandafy pandafy force-pushed the issues/87-master-subnet-validation branch from 7a4a875 to 4c7724d Compare May 14, 2021 15:22
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 99.39% when pulling 4c7724d on issues/87-master-subnet-validation into aa0e946 on master.

@nemesifier nemesifier changed the title [Fix] Exlcuded child subnets from overlapping validiation #87 [Fix] Exlcuded child subnets from overlapping validation #87 May 17, 2021
OpenWISP Contributor's Board automation moved this from Needs review to In progress May 17, 2021
nemesifier
nemesifier approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@nemesifier nemesifier merged commit 4c7724d into master May 17, 2021
OpenWISP Contributor's Board automation moved this from In progress to Done May 17, 2021
@devkapilbansal devkapilbansal changed the title [Fix] Exlcuded child subnets from overlapping validation #87 [Fix] Excluded child subnets from overlapping validation #87 May 18, 2021
@devkapilbansal devkapilbansal deleted the issues/87-master-subnet-validation branch May 18, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees

@pandafy pandafy

Labels
None yet
Projects
OpenWISP Contributor's Board
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Overlapping validation with nested subnets is bugged
3 participants
@pandafy @coveralls @nemesifier