[change!] Modified API endpoints #106 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
commented
May 20, 2021
nemesifier
requested changes
May 21, 2021
| path('subnet/<str:pk>/', api_views.subnet, name='subnet'), | ||
| path('subnet/<str:subnet_id>/hosts/', api_views.subnet_hosts, name='hosts'), | ||
| path('ip-address/<str:pk>/', api_views.ip_address, name='ip_address'), | ||
| ] |
There was a problem hiding this comment.
in other modules, we usually just define the prefix in the root urlconf or something similar, so I suggest doing that to maintain consistency. Please add ipam here:
openwisp-ipam/openwisp_ipam/urls.py
Line 14 in 7edd0c1
Changed API endpoints from "/api/v1/*" to "/api/v1/ipam/*" Closes #106
pandafy
force-pushed
the
issues/106-api-refactor
branch
from
7edd0c1
to
0f1504f
Compare
pandafy
changed the title
nemesifier
requested changes
May 26, 2021
nemesifier
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed API endpoints from "/api/v1/" to "/api/v1/ipam/"
Fixes #106