Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qa] Cleanup isort and flake8 settings in an OpenWISP module #13 #15

Merged
merged 2 commits into from
Dec 4, 2018
Merged

[qa] Cleanup isort and flake8 settings in an OpenWISP module #13 #15

merged 2 commits into from
Dec 4, 2018

Conversation

ppabcd
Copy link
Contributor

@ppabcd ppabcd commented Dec 2, 2018

Clean isort and flake. Added commit message check in travis.
Fixes #13
Fixes #14

@coveralls
Copy link

coveralls commented Dec 3, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 34

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.619%
Totals Coverage Status
Change from base Build 27: 0.0%
Covered Lines: 123
Relevant Lines: 126
💛 - Coveralls

nemesifier
nemesifier requested changes Dec 3, 2018
View reviewed changes
openwisp_ipam/models.py Show resolved Hide resolved
nemesifier
nemesifier reviewed Dec 3, 2018
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: also rebase on the current master please

@ppabcd
Copy link
Contributor Author

ppabcd commented Dec 3, 2018

all done @nemesisdesign

atb00ker
atb00ker requested changes Dec 4, 2018
View reviewed changes
Copy link
Member

@atb00ker atb00ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit header is too long.
Can you make it:

[qa] cleanup runflake8 and runisort & add commit check

@ppabcd
Copy link
Contributor Author

ppabcd commented Dec 4, 2018 •
edited
Loading

all done @atb00ker. Is i must modify model for clear flake8 errors? or create new commit for only modify this files?

@atb00ker
Copy link
Member

atb00ker commented Dec 4, 2018

@ppabcd yes please, understand why the formatting in the file is giving error and fix it accordingly, feel free to ask if you get stuck ! 😄

@ppabcd
Copy link
Contributor Author

ppabcd commented Dec 4, 2018

all done @atb00ker
gambar

@nemesifier nemesifier merged commit 58471dd into openwisp:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atb00ker atb00ker atb00ker requested changes

@nemesifier nemesifier nemesifier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ppabcd @coveralls @atb00ker @nemesifier