[admin] Added menu items #37 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
Nov 13, 2020
|
Updating openwisp-users is required for fixing the build. Waiting for this openwisp/openwisp-users#189 to be merged. |
codesankalp
force-pushed
the
issue37
branch
2 times, most recently
from
cb4fa9e
to
a0f804d
Compare
nemesifier
requested changes
Dec 20, 2020
There was a problem hiding this comment.
@codesankalp, looks good, could you add a simple admin test that check for the presence of the two menu links please?
Take a look at these tests if you're not familiar with admin tests: https://github.com/openwisp/openwisp-ipam/blob/master/openwisp_ipam/tests/test_admin.py.
Added menu items (openwisp-utils menu) for Subnet and IpAdress models. Added test for menu items in test_admin.py Also updated openwisp-utils and openwisp-users dependency in requirements files. Fixes openwisp#37
devkapilbansal
added this to Ready for review/testing
in OpenWISP Priorities for next releases
OpenWISP Priorities for next releases
automation
moved this from Ready for review/testing
to Reviewer approved
Dec 30, 2020
OpenWISP Priorities for next releases
automation
moved this from Reviewer approved
to Done
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added menu items (openwisp-utils menu) for Subnet and IpAdress models.
This is WIP PR which requires the new version release of openwisp-utils.
Fixes #37