[fix] Fixed test_get_or_create_integrity_error test

openwisp · Oct 6, 2023 · 3cf28cc · 3cf28cc
1 parent acb16bf
commit 3cf28cc
Showing 1 changed file with 16 additions and 15 deletions.
diff --git a/openwisp_monitoring/monitoring/tests/test_models.py b/openwisp_monitoring/monitoring/tests/test_models.py
@@ -133,21 +133,22 @@ def test_get_or_create_renamed_object(self):
         self.assertEqual(m2.name, m.name)
         self.assertFalse(created)
 
-    @patch.object(
-        Metric.objects,
-        'get',
-        side_effect=[
-            Metric.DoesNotExist,
-            Metric(name='lan', configuration='test_metric'),
-        ],
-    )
-    @patch.object(Metric, 'save', side_effect=IntegrityError)
-    def test_get_or_create_integrity_error(self, mocked_save, mocked_get):
-        metric, _ = Metric._get_or_create(name='lan', configuration='test_metric')
-        mocked_save.assert_called_once()
-        self.assertEqual(mocked_get.call_count, 2)
-        self.assertEqual(metric.name, 'lan')
-        self.assertEqual(metric.configuration, 'test_metric')
+    def test_get_or_create_integrity_error(self):
+        with patch.object(
+            Metric.objects,
+            'get',
+            side_effect=[
+                Metric.DoesNotExist,
+                Metric(name='lan', configuration='test_metric'),
+            ],
+        ) as mocked_get, patch.object(
+            Metric, 'save', side_effect=IntegrityError
+        ) as mocked_save:
+            metric, _ = Metric._get_or_create(name='lan', configuration='test_metric')
+            mocked_save.assert_called_once()
+            self.assertEqual(mocked_get.call_count, 2)
+            self.assertEqual(metric.name, 'lan')
+            self.assertEqual(metric.configuration, 'test_metric')
 
     def test_metric_write_wrong_related_fields(self):
         m = self._create_general_metric(name='ping', configuration='ping')