[change] WiFi session admin: switched to autocomplete filters #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed filtering using device name in WiFiAdmin Updated openwisp-controller dependency
pandafy
reviewed
Dec 6, 2022
| class DeviceOrganizationFilter(MultitenantRelatedOrgFilter): | ||
| class DeviceOrganizationFilter(MultitenantOrgFilter): |
There was a problem hiding this comment.
MultitenantRelatedOrgFilter should be used for filtering with models other than Organization. E.g. filtering WifiSessions according to device
pandafy
reviewed
Dec 6, 2022
Comment on lines
-781
to
-785
| # Filter by device name | ||
| response = self.client.get(url, {'device': org2_device.name}) | ||
| _assert_org2_wifi_session_in_response( | ||
| response, org1_interface_data, org2_interface_data | ||
| ) |
There was a problem hiding this comment.
The autocomplete filter will always perform a lookup with UUID of the object. This test was required when we were using InputFilter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depens on openwisp/openwisp-users#335.
This is not complete, a test fails.
Blockers