Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Renamed daterangepicker widget labels #487 #505

Merged
merged 2 commits into from Mar 19, 2023

Conversation

Aryamanz29
Copy link
Member

Screenshot from 2023-03-17 17-00-42

Renamed date range widget label from last week, month and year to 7 days, 30 days and 365 days to avoid any misunderstandings in the future.

Closes #487

Checks:

  • I have manually tested the proposed changes
  • I have updated the documentation (e.g. README.rst)

Renamed date range widget label from last week, month and year
to 7 days, 30 days and 365 days to avoid any misunderstandings in the future.

Closes #487
@Aryamanz29 Aryamanz29 self-assigned this Mar 17, 2023
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please flag the strings as translatable using gettext(), which should be already loaded in the global namespace (please double check).

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@nemesifier nemesifier merged commit cd6a66c into master Mar 19, 2023
9 checks passed
@nemesifier nemesifier deleted the issue-487/rename-daterangepicker-labels branch March 19, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[change] Shall we rename last week, last month, last year?
2 participants