Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Organization field in Snapshot model is redundant #128

Closed
pandafy opened this issue Jan 31, 2022 · 0 comments · Fixed by #130
Closed

[enhancement] Organization field in Snapshot model is redundant #128

pandafy opened this issue Jan 31, 2022 · 0 comments · Fixed by #130
Labels
good first issue
Projects
OpenWISP Priorities for next releases

Comments

@pandafy
Copy link
Member

pandafy commented Jan 31, 2022 •
edited

A snapshot cannot have organization different from the topology. We can safely remove the organization field.

Note for new contributors
The organization field is added using openwisp_users.mixins.OrgMixin
@pandafy pandafy added this to Backlog in OpenWISP Priorities for next releases via automation Jan 31, 2022
Aryamanz29 added a commit to Aryamanz29/openwisp-network-topology that referenced this issue Feb 2, 2022
@Aryamanz29
[enhancement] Removed org field snapshot openwisp#128
3a881ab 
Fixes openwisp#128 removed organisation field from snapshot model.
Aryamanz29 added a commit to Aryamanz29/openwisp-network-topology that referenced this issue Feb 2, 2022
@Aryamanz29
[enhancement] Removed org field snapshot openwisp#128
0ec96dc 
Fixes openwisp#128 removed organization field from snapshot model.
@Aryamanz29 Aryamanz29 mentioned this issue Feb 2, 2022
Merged
OpenWISP Priorities for next releases automation moved this from Backlog to Done Feb 2, 2022
nemesifier pushed a commit that referenced this issue Feb 2, 2022
@Aryamanz29
[change] Removed redundant organization field from Snapshot model #128
7daffcf 
Closes #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
OpenWISP Priorities for next releases
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[enhancement] Removed org field snapshot #128 Aryamanz29/openwisp-network-topology
1 participant
@pandafy