Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Added for selenium tests for opening visualizers #165 #175

Merged
merged 2 commits into from
Apr 13, 2023
Merged

[tests] Added for selenium tests for opening visualizers #165 #175

merged 2 commits into from
Apr 13, 2023

Conversation

Aryamanz29
Copy link
Member

Closes #165

@Aryamanz29 Aryamanz29 self-assigned this Apr 9, 2023
@Aryamanz29 Aryamanz29 force-pushed the issue-165/add-selenium-test-for-visualizers branch from d392938 to 50d9c15 Compare April 9, 2023 15:24
@Aryamanz29 Aryamanz29 changed the title [tests] Added for selenium test for opening visualizers #165 [tests] Added for selenium tests for opening visualizers #165 Apr 9, 2023
@Aryamanz29 Aryamanz29 force-pushed the issue-165/add-selenium-test-for-visualizers branch from 50d9c15 to a8f844a Compare April 9, 2023 15:25
@Aryamanz29 Aryamanz29 force-pushed the issue-165/add-selenium-test-for-visualizers branch from a8f844a to 1afbb32 Compare April 9, 2023 15:36
@Aryamanz29 Aryamanz29 marked this pull request as ready for review April 9, 2023 15:41
@coveralls
Copy link

coveralls commented Apr 9, 2023 •
edited
Loading

Coverage Status

Coverage: 99.289%. Remained the same when pulling b91afc8 on issue-165/add-selenium-test-for-visualizers into da8e099 on master.

nemesifier
nemesifier requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stress tested this a bit, added an error on purpose in the JS code for the admin part, and the non-admin test is failing as well because the error log is not getting cleared.

Please stress test your tests to make sure they fail properly.
If we break one view on purpose, only the test for that view should fail.
Then it's the turn of the other view.
Then both.

Remember: break the code on purpose to check your tests catch the failures.
Tests are code too and their effectivness needs to be ensured.

@Aryamanz29 Aryamanz29 force-pushed the issue-165/add-selenium-test-for-visualizers branch 2 times, most recently from cdb6522 to 26e2b4a Compare April 13, 2023 15:34
@Aryamanz29
[req-changes] Improved tests
b91afc8 
Added a workaround in the `tearDown` method that
clears the web driver console logs after each test.

Source: https://stackoverflow.com/questions/44991009/clear-chrome-browser-logs-in-selenium-python
@Aryamanz29 Aryamanz29 force-pushed the issue-165/add-selenium-test-for-visualizers branch from 26e2b4a to b91afc8 Compare April 13, 2023 18:40
nemesifier
nemesifier approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@nemesifier nemesifier merged commit 3aed89f into master Apr 13, 2023
@nemesifier nemesifier deleted the issue-165/add-selenium-test-for-visualizers branch April 13, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees

@Aryamanz29 Aryamanz29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tests] Add selenium test for opening visualizers
3 participants
@Aryamanz29 @coveralls @nemesifier