[change] Add user defined properties field in Node and Link #85

[NoumbissiValere]

Closed issue by adding a user defined properties field to Node and Link model
which users could use to defined their own properties as imported properties
are now readonly.

Closes #85

[coveralls]

Coverage increased (+0.02%) to 99.057% when pulling e418f4d on issue-85-add-properties-field into 7e8b97a on master.

[nemesifier]

Great progress!

Can you please do something to display the properties (on node and link admin change page) in a nicer way?

An admin method that simply adds <br/> elements would do or anything that makes it look better.

See my other comments below.

[nemesifier]

Great progress!

Can you please do something to display the properties (on node and link admin change page) in a nicer way?

An admin method that simply adds <br/> elements would do or anything that makes it look better.

Thanks for trying something with the properties but that's not what I meant.

Please try something like the following:

from django.utils.safestring import mark_safe

@admin.register(Node)
class NodeAdmin(NodeLinkMixin, BaseAdmin):
    # ... 
    
    fields = [
        # ... omitted other fields
        'readonly_properties',
    ]
    readonly_fields = ['readonly_properties']

    def readonly_properties(self, obj):
        output = ''
        for key, value in obj.properties.items():
            key = key.replace('_', ' ').capitalize()
            output += f'<p><strong>{key}</strong>: {value}</p>'
        return mark_safe(output)

    readonly_properties.short_description = _('properties')

This is working code but please ensure it's shared by NodeAdmin and LinkAdmin (do not duplicate it in both classes).

It looks like this:

Please also update the tests accordingly.

[nemesifier]

this module needs to be added here: https://github.com/openwisp/openwisp-network-topology/blob/master/requirements.txt

openwisp-controller is not a direct dependency. The build is not failing because openwisp-controller is being installed with an additional command to test the integration module.

[NoumbissiValere]

@nemesisdesign Thank you for this catch. I forgot to add it 😄 . But the build isn't failing because of this. the Build is failing because modify_settings is called. I tried some many fix but they didn't work. I don't think the fix should be done in this module. if we fix it here, we might be hiding a potential bug which will certainly surface again one day. My master branch is equally failing with the same error.

[NoumbissiValere]

@nemesisdesign I will rebase this once #93 is merged

[nemesifier]

Thanks! 👍