Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Organization.DoesNotExist openwisp_notifications.tasks.ns_organization_created #238

Closed
nemesifier opened this issue May 21, 2022 · 0 comments · Fixed by #242
Closed

[bug] Organization.DoesNotExist openwisp_notifications.tasks.ns_organization_created #238

nemesifier opened this issue May 21, 2022 · 0 comments · Fixed by #242
Assignees
@yashikajotwani12
Labels
bug Something isn't working
Projects
OpenWISP Contributor's Board OpenWISP Priorities for next releases [GSoC 22] Monitoring improvements

Comments

@nemesifier
Copy link
Member

nemesifier commented May 21, 2022 •
edited

When creating a new org in a prod system this exception pops up.

I think it's because we have to use transaction.on_commit on the handler as we use for the other receivers, otherwise the celery task is spawned before the transaction is saved to the DB and the organization does not exist yet.

Keep in mind that when doing this, some tests may fail because transactions are not enabled in TestCase, for that reason the on_commit may not be triggered, for that reason some tests run in TransactionTestCase
@nemesifier nemesifier added the bug Something isn't working label May 21, 2022
@nemesifier nemesifier added this to Backlog in OpenWISP Priorities for next releases via automation May 21, 2022
@nemesifier nemesifier added this to To do (general) in OpenWISP Contributor's Board via automation May 21, 2022
@nemesifier nemesifier moved this from To do (general) to To do (Python & Django) in OpenWISP Contributor's Board May 21, 2022
@nemesifier nemesifier moved this from Backlog to To do in OpenWISP Priorities for next releases May 21, 2022
@yashikajotwani12 yashikajotwani12 self-assigned this Jun 8, 2022
yashikajotwani12 added a commit that referenced this issue Jun 10, 2022
@yashikajotwani12
[bug] Organization.DoesNotExist #238
870c7c8 
Fixes #238
@yashikajotwani12 yashikajotwani12 mentioned this issue Jun 10, 2022
Merged
yashikajotwani12 added a commit that referenced this issue Jun 10, 2022
@yashikajotwani12
[bug] Organization.DoesNotExist #238
0ebe352 
Fixes #238
yashikajotwani12 added a commit that referenced this issue Jun 10, 2022
@yashikajotwani12
[bug] Organization.DoesNotExist #238
244c330 
Fixes #238
yashikajotwani12 added a commit that referenced this issue Jun 10, 2022
@yashikajotwani12
[bug] Organization.DoesNotExist #238
0ecd45f 
Fixes #238
@yashikajotwani12 yashikajotwani12 moved this from To do to In progress in [GSoC 22] Monitoring improvements Jun 10, 2022
yashikajotwani12 added a commit that referenced this issue Jun 10, 2022
@yashikajotwani12
[bug] Organization matching query does not exist #238
ff280ae 
Fixes #238
@yashikajotwani12 yashikajotwani12 moved this from In progress to Review in progress in [GSoC 22] Monitoring improvements Jun 20, 2022
OpenWISP Contributor's Board automation moved this from To do (Python & Django) to Done Jun 30, 2022
OpenWISP Priorities for next releases automation moved this from To do to Done Jun 30, 2022
nemesifier pushed a commit that referenced this issue Jun 30, 2022
@yashikajotwani12
[fix] Organization matching query does not exist #238
3b4d584 
Fixes #238
[GSoC 22] Monitoring improvements automation moved this from Review in progress to Done Jun 30, 2022
nemesifier pushed a commit that referenced this issue Jun 30, 2022
@yashikajotwani12 @nemesifier
[fix] Organization matching query does not exist #238
9c2b38a 
Fixes #238

(cherry picked from commit 3b4d584)
@pandafy pandafy mentioned this issue Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yashikajotwani12 yashikajotwani12

Labels
bug Something isn't working
Projects
OpenWISP Contributor's Board
  
Done
OpenWISP Priorities for next releases
  
Done
[GSoC 22] Monitoring improvements
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] Organization matching query does not exist #238 openwisp/openwisp-notifications
2 participants
@nemesifier @yashikajotwani12