Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qa] Enable linting for css and js #185 #218

Merged
merged 2 commits into from
Feb 12, 2022
Merged

[qa] Enable linting for css and js #185 #218

merged 2 commits into from
Feb 12, 2022

Conversation

yashikajotwani12
Copy link
Contributor

@yashikajotwani12 yashikajotwani12 commented Jan 19, 2022 •
edited

Fixes #185
Screenshot from 2022-01-19 18-59-24

nemesifier
nemesifier requested changes Jan 25, 2022
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashikajotwani12 please double check your version of black, it seems it's not in line with what the CI uses and hence there are differences which are being rejected by the qa checks.

@nemesifier nemesifier added this to In progress in OpenWISP Priorities for next releases via automation Jan 25, 2022
@yashikajotwani12
Copy link
Contributor Author

@yashikajotwani12 please double check your version of black, it seems it's not in line with what the CI uses and hence there are differences which are being rejected by the qa checks.

Okay! Trying to improve this.

@yashikajotwani12
Copy link
Contributor Author

@yashikajotwani12 please double check your version of black, it seems it's not in line with what the CI uses and hence there are differences which are being rejected by the qa checks.

I have checked and it aligns with the version which CI uses.

OpenWISP Priorities for next releases automation moved this from In progress to Reviewer approved Feb 12, 2022
@nemesifier nemesifier merged commit effc691 into openwisp:master Feb 12, 2022
OpenWISP Priorities for next releases automation moved this from Reviewer approved to Done Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenWISP Priorities for next releases
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[qa] Enable linting for css and js
2 participants
@yashikajotwani12 @nemesifier