[Fix] Error handling send email notification #179 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
requested changes
Feb 3, 2022
There was a problem hiding this comment.
@aagman945 kindly read the contributing guidelines and update your editor settings as mentioned here https://openwisp.io/docs/developer/contributing.html#avoiding-unnecessary-changes.
Doing so would have reduced requested changes in this PR. The commit message needs to be updated as well.
Also, always run ./run-qa-check before pushing changes to GitHub.
pandafy
added this to In progress
in OpenWISP Priorities for next releases
via automation
aagman945
changed the title
pandafy
requested changes
Feb 11, 2022
pandafy
approved these changes
Feb 11, 2022
OpenWISP Priorities for next releases
automation
moved this from In progress
to Reviewer approved
Feb 11, 2022
|
Thanks for contributing @aagman945! |
OpenWISP Priorities for next releases
automation
moved this from Reviewer approved
to Done
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added exception handling for the issue #179 and test for the same . So ,If throws exception the function will be returned empty and mail will not be sent.