[fix] Swagger api doc issue #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
Feb 15, 2022
There was a problem hiding this comment.
@aagman945 can you please add a couple of tests to avoid the coverage to decrease and hence fail the build?
pandafy
reviewed
Feb 17, 2022
Comment on lines
+52
to
+53
| if self.request.user.is_anonymous: | ||
| return |
There was a problem hiding this comment.
@nemesisdesign I don't think these changes makes much logical sense. The permission_classes of this view contains IsAuthenticated. Therefore, this view will not be visible to AnonymousUser.
Regarding swagger issues, it only allows unauthenticated user to open API docs when DEBUG is set to True. Since that only occurs in the test project and not in deployments (ansible-openwisp2), we should consider updating settings of the project to ignore that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #169