[tests] Added test for changes in post_save_radiusaccounting

openwisp_radius/integrations/monitoring/tasks.py

@@ -115,7 +115,7 @@ def post_save_radiusaccounting(
         logger.warning(
             f'Device object not found with MAC "{called_station_id}"'
             f' and organization "{organization_id}".'
-            ' Skipping radius_acc metric writing!'
+            ' The metric will be written without a related object!'
         )
         object_id = None
         content_type = None
@@ -142,15 +142,18 @@ def post_save_radiusaccounting(
             'location_id': location_id,
         },
     )
-    print('===========================================')
     metric.write(
         input_octets,
         extra_values={
             'output_octets': output_octets,
             'username': sha1_hash(username),
         },
     )
-    if created and object_id:
+    if not object_id:
+        # Adding a chart requires all parameters of extra_tags to be present.
+        # A chart cannot be created without object_id and content_type.
+        return
+    if created:
         for configuration in metric.config_dict['charts'].keys():
             chart = Chart(metric=metric, configuration=configuration)
             chart.full_clean()

openwisp_radius/integrations/monitoring/tests/mixins.py

@@ -39,6 +39,10 @@ def device_model(self):
     def metric_model(self):
         return load_model('monitoring', 'Metric')
 
+    @property
+    def chart_model(self):
+        return load_model('monitoring', 'Chart')
+
     @property
     def location_model(self):
         return load_model('geo', 'Location')

openwisp_radius/integrations/monitoring/tests/test_metrics.py

@@ -180,6 +180,78 @@ def test_post_save_radiusaccounting(self, *args):
         self.assertEqual(points['traces'][0][1][-1], 1)
         self.assertEqual(points['summary'], {'mobile_phone': 1})
 
+    @patch('logging.Logger.warning')
+    def test_post_save_radius_accounting(self, mocked_logger):
+        """
+        This test checks that radius accounting metric is created
+        even if the device could not be found with the called_station_id.
+        This scenario can happen on an installations which uses the
+        convert_called_station_id feature, but it is not configured
+        properly leaving all called_station_id unconverted.
+        """
+        user = self._create_user()
+        reg_user = self._create_registered_user(user=user)
+        options = _RADACCT.copy()
+        options.update(
+            {
+                'unique_id': '117',
+                'username': user.username,
+                'called_station_id': '11:22:33:44:55:66',
+                'calling_station_id': '00:00:00:00:00:00',
+                'input_octets': '8000000000',
+                'output_octets': '9000000000',
+            }
+        )
+        options['stop_time'] = options['start_time']
+        # Remove calls for user registration from mocked logger
+        mocked_logger.reset_mock()
+
+        self._create_radius_accounting(**options)
+        self.assertEqual(
+            self.metric_model.objects.filter(
+                configuration='radius_acc',
+                name='RADIUS Accounting',
+                key='radius_acc',
+                object_id=None,
+                content_type=None,
+                extra_tags={
+                    'called_station_id': '11:22:33:44:55:66',
+                    'calling_station_id': '00:00:00:00:00:00',
+                    'location_id': None,
+                    'method': reg_user.method,
+                    'organization_id': str(self.default_org.id),
+                },
+            ).count(),
+            1,
+        )
+        metric = self.metric_model.objects.filter(configuration='radius_acc').first()
+        # A dedicated chart for this metric was not created since the
+        # related device was not identified by the called_station_id.
+        # The data however can be retrieved from the general charts.
+        self.assertEqual(metric.chart_set.count(), 0)
+        general_traffic_chart = self.chart_model.objects.get(
+            configuration='gen_rad_traffic'
+        )
+        points = general_traffic_chart.read()
+        self.assertEqual(points['traces'][0][0], 'download')
+        self.assertEqual(points['traces'][0][1][-1], 8)
+        self.assertEqual(points['traces'][1][0], 'upload')
+        self.assertEqual(points['traces'][1][1][-1], 9)
+        self.assertEqual(points['summary'], {'upload': 9, 'download': 8})
+
+        general_session_chart = self.chart_model.objects.get(
+            configuration='gen_rad_session'
+        )
+        points = general_session_chart.read()
+        self.assertEqual(points['traces'][0][0], 'mobile_phone')
+        self.assertEqual(points['traces'][0][1][-1], 1)
+        self.assertEqual(points['summary'], {'mobile_phone': 1})
+        mocked_logger.assert_called_once_with(
+            f'Device object not found with MAC "{options["called_station_id"]}"'
+            f' and organization "{self.default_org.id}".'
+            ' The metric will be written without a related object!'
+        )
+
     @patch('openwisp_monitoring.monitoring.models.Metric.batch_write')
     @patch('logging.Logger.warning')
     def test_post_save_radiusaccounting_edge_cases(