Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api/radius] Fix BatchView permission and authorization #94

Closed
nemesifier opened this issue Jun 4, 2020 · 0 comments · Fixed by #131
Closed

[api/radius] Fix BatchView permission and authorization #94

nemesifier opened this issue Jun 4, 2020 · 0 comments · Fixed by #131
Labels
bug Something isn't working important Higher priority or release blocker
Projects
Hacktoberfest 2020 Roadmap [GSoC20] Merge modules

Comments

@nemesifier
Copy link
Member

nemesifier commented Jun 4, 2020 •
edited

The BatchView of the API should be usable only by admin/staff users.

The organization should be part of the URL, eg: /api/v1/<org-slug>/radius/batch/.

It should use the user authentication from openwisp-users (not the other authentication designed to be used by freeradius).
It should use the django permissions to reject requests coming from users which do not have permissions to manipulate batch objects, it should allow superusers though.

Test will have to be changed. API docs need to be updated.
@nemesifier nemesifier added the bug Something isn't working label Jun 4, 2020
@nemesifier nemesifier added this to To do in Hacktoberfest 2020 via automation Jun 6, 2020
@nemesifier nemesifier added this to To do general in Roadmap via automation Jun 6, 2020
@nemesifier nemesifier added the important Higher priority or release blocker label Jun 29, 2020
@nemesifier nemesifier mentioned this issue Jul 2, 2020
Merged
@nemesifier nemesifier added this to To do in [GSoC20] Merge modules via automation Jul 4, 2020
@atb00ker atb00ker moved this from Backlog to To do (Next) in [GSoC20] Merge modules Jul 13, 2020
atb00ker added a commit to atb00ker/openwisp-radius that referenced this issue Jul 17, 2020
@atb00ker
[fix] BatchView permission and authorization openwisp#94
b805811 
Closes openwisp#94
@atb00ker atb00ker mentioned this issue Jul 17, 2020
Merged
atb00ker added a commit to atb00ker/openwisp-radius that referenced this issue Jul 17, 2020
@atb00ker
[fix] BatchView permission and authorization openwisp#94
bdf1411 
Closes openwisp#94
atb00ker added a commit to atb00ker/openwisp-radius that referenced this issue Jul 17, 2020
@atb00ker
[fix] BatchView permission and authorization openwisp#94
e944cad 
Closes openwisp#94
atb00ker added a commit to atb00ker/openwisp-radius that referenced this issue Jul 17, 2020
@atb00ker
[fix] BatchView permission and authorization openwisp#94
62f7900 
Closes openwisp#94
atb00ker added a commit to atb00ker/openwisp-radius that referenced this issue Jul 17, 2020
@atb00ker
[fix] BatchView permission and authorization openwisp#94
4d488dd 
Closes openwisp#94
@atb00ker atb00ker moved this from To do (Next) to In progress in [GSoC20] Merge modules Jul 17, 2020
atb00ker added a commit to atb00ker/openwisp-radius that referenced this issue Jul 21, 2020
@atb00ker
[fix] BatchView permission and authorization openwisp#94
edd3bad 
Closes openwisp#94
Hacktoberfest 2020 automation moved this from To do to Done Jul 21, 2020
Roadmap automation moved this from To do general to Done Jul 21, 2020
nemesifier pushed a commit that referenced this issue Jul 21, 2020
@atb00ker
[fix] BatchView permission and authorization #94
3013b67 
Closes #94
[GSoC20] Merge modules automation moved this from In progress to Done Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working important Higher priority or release blocker
Projects
Roadmap
  
Done
Hacktoberfest 2020
  
Done
[GSoC20] Merge modules
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] BatchView permission and authorization #94 atb00ker/openwisp-radius
1 participant
@nemesifier