Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[radius] Allow customizing User model #87 #106

Merged
merged 3 commits into from Jun 19, 2020
Merged

[radius] Allow customizing User model #87 #106

merged 3 commits into from Jun 19, 2020

Conversation

atb00ker
Copy link
Member

@atb00ker atb00ker commented Jun 7, 2020 •
edited

TODO: Change the link of the openwisp-users installation.
Closes #87

@atb00ker atb00ker force-pushed the issues/87 branch 2 times, most recently from db0d321 to 3772d83 Compare June 7, 2020 11:38
atb00ker
atb00ker commented Jun 7, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@atb00ker atb00ker added this to In progress in [GSoC20] Merge modules via automation Jun 7, 2020
@atb00ker atb00ker moved this from In progress to Ready for review in [GSoC20] Merge modules Jun 7, 2020
@coveralls
Copy link

coveralls commented Jun 7, 2020 •
edited

Pull Request Test Coverage Report for Build 298

  • 11 of 11 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 98.809%
Totals Coverage Status
Change from base Build 288: 0.004%
Covered Lines: 1908
Relevant Lines: 1931
💛 - Coveralls

nemesifier
nemesifier requested changes Jun 8, 2020
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left one comment, will test next

tests/openwisp2/sample_users/models.py Outdated Show resolved Hide resolved
[GSoC20] Merge modules automation moved this from Ready for review to Open Pull-Requests Jun 8, 2020
nemesifier
nemesifier reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I need some time to test this before merging but it looks very good. 👍

@atb00ker atb00ker self-assigned this Jun 11, 2020
@atb00ker atb00ker moved this from Open Pull-Requests to Ready for review in [GSoC20] Merge modules Jun 11, 2020
@atb00ker atb00ker force-pushed the issues/87 branch 4 times, most recently from 14ab9e1 to 86058ee Compare June 11, 2020 11:23
nemesifier
nemesifier previously approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, will merge after double checking the build after the travis change I just made

.travis.yml Outdated Show resolved Hide resolved
[GSoC20] Merge modules automation moved this from Ready for review to Open Pull-Requests Jun 19, 2020
[GSoC20] Merge modules automation moved this from Open Pull-Requests to Ready for review Jun 19, 2020
@nemesifier nemesifier merged commit 7348bb8 into openwisp:master Jun 19, 2020
[GSoC20] Merge modules automation moved this from Ready for review to Done Jun 19, 2020
@atb00ker atb00ker deleted the issues/87 branch June 19, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees

@atb00ker atb00ker

Labels
None yet
Projects
No open projects
[GSoC20] Merge modules
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[radius] Allow customizing User model
3 participants
@atb00ker @coveralls @nemesifier