[fix] cache checks for string 'uuid' not org's uuid #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atb00ker
changed the title
Pull Request Test Coverage Report for Build 353
💛 - Coveralls |
atb00ker
commented
Jul 2, 2020
Comment on lines
+1446
to
+1451
| with self.subTest('Force changed corrupt cache returns 403'): | ||
| cache.set(rad.organization.pk, 'wrong-value') | ||
| response = self.client.post( | ||
| post_url, {'username': 'tester', 'password': 'tester'} | ||
| ) | ||
| self.assertEqual(response.status_code, 403) |
There was a problem hiding this comment.
Added a new testcase to make testing of the cache more robust.
If the value of cache is not as expected (here forcefullly changed), then it returns 403; this test would have reported the problem solved in this issue.
atb00ker
changed the title
atb00ker
moved this from Open Pull-Requests
to Ready for review
in [GSoC20] Merge modules
nemesifier
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.