Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] Improve readability + formatting #134

Merged
merged 1 commit into from Jul 21, 2020
Merged

[minor] Improve readability + formatting #134

merged 1 commit into from Jul 21, 2020

Conversation

atb00ker
Copy link
Member

@atb00ker atb00ker commented Jul 20, 2020 •
edited

No functional change, it only seems easier to read this way. Merge if you feel this provides readability improvement.

Blocked: #135

@atb00ker atb00ker force-pushed the minor-settings-name branch 2 times, most recently from a25818f to edb3f43 Compare July 20, 2020 08:01
atb00ker
atb00ker commented Jul 20, 2020
View reviewed changes
Copy link
Member Author

@atb00ker atb00ker left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because openwisp-users master branch changes, checking and fixing them...

openwisp_radius/tests/test_social.py Outdated Show resolved Hide resolved
@atb00ker
Copy link
Member Author

atb00ker commented Jul 20, 2020 •
edited

Test will pass after #135 is merged and rebased on this.

@atb00ker atb00ker self-assigned this Jul 20, 2020
@atb00ker atb00ker added this to In progress in [GSoC20] Merge modules via automation Jul 20, 2020
@atb00ker atb00ker moved this from In progress to Open Pull-Requests in [GSoC20] Merge modules Jul 20, 2020
@atb00ker atb00ker added the blocked Blocked by another issue / pr or task label Jul 20, 2020
@atb00ker atb00ker changed the title [minor] Improve settings readability [minor] Improve readability + formatting Jul 20, 2020
nemesifier
nemesifier requested changes Jul 21, 2020
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @atb00ker, see my comment below

openwisp_radius/tests/test_social.py Outdated Show resolved Hide resolved
@atb00ker atb00ker moved this from Open Pull-Requests to Ready for review in [GSoC20] Merge modules Jul 21, 2020
@coveralls
Copy link

coveralls commented Jul 21, 2020 •
edited

Pull Request Test Coverage Report for Build 422

  • 11 of 11 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.196%
Totals Coverage Status
Change from base Build 418: 0.0%
Covered Lines: 1975
Relevant Lines: 1991
💛 - Coveralls

@nemesifier nemesifier merged commit 99f1619 into openwisp:master Jul 21, 2020
[GSoC20] Merge modules automation moved this from Ready for review to Done Jul 21, 2020
@atb00ker atb00ker deleted the minor-settings-name branch July 22, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees

@atb00ker atb00ker

Labels
blocked Blocked by another issue / pr or task
Projects
No open projects
[GSoC20] Merge modules
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atb00ker @coveralls @nemesifier