[bug] unexpected freeradius authorize failed #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atb00ker
commented
Aug 13, 2020
| @@ -191,7 +191,7 @@ def get_user(self, request): | |||
| # ensure user is member of the authenticated org | |||
| # or RadiusToken for the user exists. | |||
| if ( | |||
| RadiusToken.objects.filter(user=user, can_auth=True).exists() | |||
| RadiusToken.objects.filter(user=user).exists() | |||
There was a problem hiding this comment.
Why can_auth is removed here:
Send auth with "username=admin&password=admin"
Success
Send auth with "username=admin&password=radtoken"
Success
Send auth with "username=admin&password=admin"
Failed Unexpectedly
Why? Because can_auth=True is false now!
Fix: remove can_auth from get_user() and only keep it in check_user_token()
There was a problem hiding this comment.
can you please add a test for this bug? Should be quick.
nemesifier
requested changes
Aug 13, 2020
| @@ -191,7 +191,7 @@ def get_user(self, request): | |||
| # ensure user is member of the authenticated org | |||
| # or RadiusToken for the user exists. | |||
| if ( | |||
| RadiusToken.objects.filter(user=user, can_auth=True).exists() | |||
| RadiusToken.objects.filter(user=user).exists() | |||
There was a problem hiding this comment.
can you please add a test for this bug? Should be quick.
[GSoC20] Merge modules
automation
moved this from Ready for review
to Open Pull-Requests
Aug 13, 2020
atb00ker
force-pushed
the
minor-fix-can-auth
branch
3 times, most recently
from
c0ae381
to
2dbba63
Compare
nemesifier
requested changes
Aug 19, 2020
atb00ker
force-pushed
the
minor-fix-can-auth
branch
from
2dbba63
to
28254c1
Compare
atb00ker
moved this from Open Pull-Requests
to Ready for review
in [GSoC20] Merge modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.