[change] Adds check for valid prefix in batch creation #365 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bsande6 Can you please explain why this change is necessary? If it is, add some test cases too |
atb00ker
reviewed
Jan 29, 2022
There was a problem hiding this comment.
@devkapilbansal It's required because currently any character is allowed in the radius batch user creation form, but users can have only limited characters.
@bsande6 please:
- Link the following the pr description and commit: [bug] invalid username allowed #365
- Add a test to ensure that if an illegal character is entered, the form rejects the input, please checkout the existing tests for help: https://github.com/openwisp/openwisp-radius/blob/master/openwisp_radius/tests/test_batch_add_users.py
- Tests are failing, please check them as well!
If you need further information, please reach out on the gitter development channel!
bsande6
changed the title
bsande6
force-pushed
the
invalid-username-fix
branch
from
763bab4
to
9856d9f
Compare
atb00ker
approved these changes
Feb 8, 2022
…nwisp#365 Adds a check such that the prefix in a batch user creation only accepts letters, numbers and the special characters @/./+/-/_ Related to openwisp#365
atb00ker
force-pushed
the
invalid-username-fix
branch
from
9856d9f
to
d718641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@atb00ker This commit adds a check such that the prefix in a batch user creation only accepts letters, numbers and the special characters @/./+/-/_